summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLogan Hunt <loganhunt@simponic.xyz>2022-05-21 00:57:02 -0700
committerLogan Hunt <loganhunt@simponic.xyz>2022-05-21 00:57:02 -0700
commit1c8ce46697cfa838550378d52f2528c97a44a4b3 (patch)
tree4dda0a9d80cc30130ee0321751851ff20258d97d
parent893af13e3cd54062d51069f40be8269668dd5ec3 (diff)
downloadaggiedit-master.tar.gz
aggiedit-master.zip
Fix minor bugs in forms not showing errors and whatnotHEADmaster
-rw-r--r--assets/css/app.css3
-rw-r--r--lib/aggiedit/rooms/post.ex2
-rw-r--r--lib/aggiedit_web/templates/layout/root.html.heex7
-rw-r--r--lib/aggiedit_web/views/error_helpers.ex2
4 files changed, 7 insertions, 7 deletions
diff --git a/assets/css/app.css b/assets/css/app.css
index 0bab67f..0d7e35a 100644
--- a/assets/css/app.css
+++ b/assets/css/app.css
@@ -27,10 +27,9 @@
.alert:empty {
display: none;
}
-.invalid-feedback {
+.error-feedback {
color: #a94442;
display: block;
- margin: -1rem 0 2rem;
}
/* LiveView specific classes for your customization */
diff --git a/lib/aggiedit/rooms/post.ex b/lib/aggiedit/rooms/post.ex
index e1aa59a..8a14829 100644
--- a/lib/aggiedit/rooms/post.ex
+++ b/lib/aggiedit/rooms/post.ex
@@ -21,7 +21,7 @@ defmodule Aggiedit.Rooms.Post do
def changeset(post, attrs) do
post
|> cast(attrs, [:title, :body, :score])
- |> validate_required([:title, :body])
+ |> validate_required([:title])
end
def change_user(post, user) do
diff --git a/lib/aggiedit_web/templates/layout/root.html.heex b/lib/aggiedit_web/templates/layout/root.html.heex
index 861ed8b..d8ce08e 100644
--- a/lib/aggiedit_web/templates/layout/root.html.heex
+++ b/lib/aggiedit_web/templates/layout/root.html.heex
@@ -6,13 +6,14 @@
<meta name="viewport" content="width=device-width, initial-scale=1.0"/>
<%= csrf_meta_tag() %>
<%= live_title_tag assigns[:page_title] || "Aggiedit" %>
- <link phx-track-static rel="stylesheet" href={Routes.static_path(@conn, "/assets/app.css")}/>
- <script phx-track-static type="text/javascript" src={Routes.static_path(@conn, "/assets/app.js")}></script>
- <link rel="icon" type="image/x-icon" href="/favicon.ico" />
<link href="https://cdn.jsdelivr.net/npm/bootstrap@5.1.3/dist/css/bootstrap.min.css" rel="stylesheet" integrity="sha384-1BmE4kWBq78iYhFldvKuhfTAU6auU8tT94WrHftjDbrCEXSU1oBoqyl2QvZ6jIW3" crossorigin="anonymous">
<script src="https://cdn.jsdelivr.net/npm/bootstrap@5.1.3/dist/js/bootstrap.bundle.min.js" integrity="sha384-ka7Sk0Gln4gmtz2MlQnikT1wXgYsOg+OMhuP+IlRH9sENBO0LRn5q+8nbTov4+1p" crossorigin="anonymous"></script>
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/bootstrap-icons@1.8.0/font/bootstrap-icons.css">
+
+ <link phx-track-static rel="stylesheet" href={Routes.static_path(@conn, "/assets/app.css")}/>
+ <script phx-track-static type="text/javascript" src={Routes.static_path(@conn, "/assets/app.js")}></script>
+ <link rel="icon" type="image/x-icon" href="/favicon.ico" />
</head>
<body class="bg-secondary min-vh-100">
<header>
diff --git a/lib/aggiedit_web/views/error_helpers.ex b/lib/aggiedit_web/views/error_helpers.ex
index 651e48f..f2cf2b5 100644
--- a/lib/aggiedit_web/views/error_helpers.ex
+++ b/lib/aggiedit_web/views/error_helpers.ex
@@ -11,7 +11,7 @@ defmodule AggieditWeb.ErrorHelpers do
def error_tag(form, field) do
Enum.map(Keyword.get_values(form.errors, field), fn error ->
content_tag(:span, translate_error(error),
- class: "invalid-feedback",
+ class: "error-feedback", # changed from invalid-feedback because bootstrap 5 has invalid-feedback already defined
phx_feedback_for: input_name(form, field)
)
end)