POST record with id to update to fix cloudflare 500

1 files changed, 26 insertions, 5 deletions

diff --git a/adapters/external_dns/cloudflare/cloudflare.go b/adapters/external_dns/cloudflare/cloudflare.go
index c302037..4f9e208 100644
--- a/adapters/external_dns/cloudflare/cloudflare.go
+++ b/adapters/external_dns/cloudflare/cloudflare.go
@@ -21,15 +21,11 @@ type CloudflareExternalDNSAdapter struct {
 
 func (adapter *CloudflareExternalDNSAdapter) CreateDNSRecord(record *database.DNSRecord) (string, error) {
 	url := fmt.Sprintf("https://api.cloudflare.com/client/v4/zones/%s/dns_records", adapter.ZoneId)
-
-	reqBody := fmt.Sprintf(`{"type":"%s","name":"%s","content":"%s","ttl":%d,"proxied":false}`, record.Type, record.Name, record.Content, record.TTL)
-	payload := strings.NewReader(reqBody)
+	payload := strings.NewReader(encodeDNSRecord(record))
 
 	req, _ := http.NewRequest("POST", url, payload)
-
 	req.Header.Add("Authorization", "Bearer "+adapter.APIToken)
 	req.Header.Add("Content-Type", "application/json")
-
 	res, err := http.DefaultClient.Do(req)
 	if err != nil {
 		return "", err
@@ -53,6 +49,27 @@ func (adapter *CloudflareExternalDNSAdapter) CreateDNSRecord(record *database.DN
 	return result.ID, nil
 }
 
+func (adapter *CloudflareExternalDNSAdapter) UpdateDNSRecord(record *database.DNSRecord) error {
+	url := fmt.Sprintf("https://api.cloudflare.com/client/v4/zones/%s/dns_records/%s", adapter.ZoneId, record.ID)
+	payload := strings.NewReader(encodeDNSRecord(record))
+
+	req, _ := http.NewRequest("PUT", url, payload)
+	req.Header.Add("Authorization", "Bearer "+adapter.APIToken)
+	req.Header.Add("Content-Type", "application/json")
+	res, err := http.DefaultClient.Do(req)
+	if err != nil {
+		return err
+	}
+
+	defer res.Body.Close()
+	body, _ := io.ReadAll(res.Body)
+	if res.StatusCode != 200 {
+		return fmt.Errorf("error updating dns record: %s", body)
+	}
+
+	return nil
+}
+
 func (adapter *CloudflareExternalDNSAdapter) DeleteDNSRecord(id string) error {
 	url := fmt.Sprintf("https://api.cloudflare.com/client/v4/zones/%s/dns_records/%s", adapter.ZoneId, id)
 
@@ -74,3 +91,7 @@ func (adapter *CloudflareExternalDNSAdapter) DeleteDNSRecord(id string) error {
 
 	return nil
 }
+
+func encodeDNSRecord(record *database.DNSRecord) string {
+	return fmt.Sprintf(`{"type":"%s","name":"%s","content":"%s","ttl":%d,"proxied":false}`, record.Type, record.Name, record.Content, record.TTL)
+}